nick / react-native-carousel

Carousel component for react-native
MIT License
458 stars 107 forks source link

Not working in android #64

Open waleedarshad-vf opened 8 years ago

ruskid commented 8 years ago

confirmed. And no information provided about android support!

jamealg commented 8 years ago

It's working on my Nexus 6P running Android 6.0.1. I'm still on RN 0.29.2 though so perhaps a recent update to RN broke it?

nick commented 8 years ago

Any pull requests to fix this issue gladly accepted.

chromonav commented 8 years ago

working on rn 30

tioback commented 8 years ago

@chromonav in my case, indicators are not showing in Android, and in iOS, they are showing out of bounds.

simulator screen shot 7 de set de 2016 12 40 42

tioback commented 8 years ago

The problem seems to be indicatorOffset. It's original value is 250, which sends the indicators nearly to the top of the screen.

Other than that, if I set indicatorOffset={10}, Android is perfect, check PR #31

javaxiu commented 8 years ago

it is not working on my android project either, any one help me?

symmetriccurve commented 7 years ago

@javaxiu have you able to solve your issue. ?

Works seamlessly on "react-native": "^0.29.1"

duzliang commented 7 years ago

don't work on react-native 0.38

duzliang commented 7 years ago

this is maybe a react-native bug, I have read the document but can't find it

mikelambert commented 7 years ago

For anyone saying it "doesn't work", you'll probably have to give an explanation of what exactly isn't working (display, interaction, the indicator problems mentioned above, etc).

If your problem is "the view shows up empty", and your <Carousel> is in a <ScrollView>, you may be encountering https://github.com/facebook/react-native/issues/8088. Set the containing <ScrollView> to removeClippedSubviews={false} and things should work (though it's not a great solution for performance reasons).

javaxiu commented 7 years ago

@symmetriccurve it turns out canvas was not suitable to display(too big or too small). try to print container's size on your console for debug. i haven't use this module for a while. wish it is helpful

bradsolves commented 7 years ago

Running rn0.41 I was able to merge both the Android and iOS component definitions. This resolved the issue for me. see PR #76

chilijung commented 7 years ago

hi everyone, this project seems abandoned for a while. So I've make lots of improvements of this library. If you are looking for alternative solutions see here https://github.com/Canner/react-native-carousel-view. thanks!

SupriyaKalghatgi commented 7 years ago

@tioback Setting indicatorOffset to 10 dd'nt help me

SupriyaKalghatgi commented 7 years ago

@mikelambert I am using Carousel within ScrollView But adding removeClippedSubviews={false} to ScrollView dd'nt help me either