search

nick8325 / quickcheck

Automatic testing of Haskell programs.
Other
713 stars 119 forks source link

Support GHC-9.0 (template-haskell-2.17) and allow `StarT`-kinded TVs #314

Closed buggymcbugfix closed 3 years ago

buggymcbugfix commented 4 years ago

(1) Fix bad unipattern in lambda (2) Update patterns for updated TyVarBndr from template-haskell-2.17.0

While opening this PR I noticed that #311 also addresses (2), however it addresses (1) differently and apparently incorrectly.

The uni-patterned lambda would previously incorrectly fail on KindedTV nm StarT and #311 unnecessarily reproduces this failure.

This patch is also shorter and clearer.

phadej commented 4 years ago

ping @RyanGlScott

RyanGlScott commented 4 years ago

Is there something in particular you want me to look at? Keep in mind that I'm not a maintainer of this library, so I don't really understand what this code even does at present.

phadej commented 4 years ago

@RyanGlScott does the changes between your patch and this one make sense to you?

RyanGlScott commented 4 years ago

I guess? Admittedly, I wrote that patch as quickly as possible to get the Hackage ecosystem compiling on HEAD, and I even preserved the semantics of the partial uni-pattern. (Again, it's worth emphasizing that I don't know what this code in QuickCheck is doing.)

Generally speaking, I like code without partial uni-patterns, so if this patch gets rid of that, then I'm all for it.

buggymcbugfix commented 4 years ago

In that case, do you want to close #311 to avoid confusion, @phadej?

galenhuntington commented 4 years ago

It looks like a #endif got accidentally inserted here, which is why the tests are failing: https://github.com/nick8325/quickcheck/pull/314/commits/b45351fc824a5a2c16312b731749ac7983a4deac#diff-a2ca13afe67e562cd605374d2e9bb810L108-R114

buggymcbugfix commented 4 years ago

@galenhuntington good spot, thanks. Should be fixed now.

nick8325 commented 3 years ago

Thanks a lot!

ethercrow commented 3 years ago

@nick8325 Hi! Could you please release this on hackage?

nick8325 commented 3 years ago

Done!