search

nicka / coinboss

⚡️💸💰 A Serverless Coinbase tradingbot.
MIT License
115 stars 28 forks source link

Make sure the service name is the same everywhere #6

Closed svdgraaf closed 7 years ago

svdgraaf commented 7 years ago

The naming convention differs. Sometimes with capital, sometimes without. It's better to have them consistent, as this makes things more predictable.

Merging this PR will make everything use the central service designator, which will always be consistent.

svdgraaf commented 7 years ago

@nicka updated :)

tvb commented 7 years ago

@svdgraaf @nicka This change actually limits the way to push different metrics (like from different exchanges) to different namespaces. It is set to to service: ${file(package.json):name} which is 

{
  "name": "coinboss",
...

Also, it is set to all lowercase while all namespaces in CloudWatch are with a capital.