search

nicka / coinboss

⚡️💸💰 A Serverless Coinbase tradingbot.
MIT License
115 stars 28 forks source link

Kraken #9

Closed tvb closed 4 years ago

tvb commented 7 years ago

Adding the Kraken Exchange

nicka commented 7 years ago

Sorry, please rebase... Added CI

tvb commented 7 years ago

@nicka done. I will fix the errors.

nicka commented 7 years ago

eslint --fix 😉

tvb commented 7 years ago

@nicka

Not quite:

$ eslint . --fix
Cannot find module 'eslint-config-airbnb-base'
Referenced from: coinboss/.eslintrc
Error: Cannot find module 'eslint-config-airbnb-base'
Referenced from: coinboss/.eslintrc
    at ModuleResolver.resolve (/usr/local/lib/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/usr/local/lib/node_modules/eslint/lib/config/config-file.js:515:25)
    at load (/usr/local/lib/node_modules/eslint/lib/config/config-file.js:584:26)
    at configExtends.reduceRight (/usr/local/lib/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight (native)
    at applyExtends (/usr/local/lib/node_modules/eslint/lib/config/config-file.js:405:28)
    at loadFromDisk (/usr/local/lib/node_modules/eslint/lib/config/config-file.js:556:22)
    at Object.load (/usr/local/lib/node_modules/eslint/lib/config/config-file.js:592:20)
    at Config.getLocalConfigHierarchy (/usr/local/lib/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/usr/local/lib/node_modules/eslint/lib/config.js:182:43)
nicka commented 7 years ago

Did you run yarn before running eslint? 😊

tvb commented 7 years ago

I did now, same outcome.

lukasnagl commented 7 years ago

Likely yarn eslint . --fix if you haven’t installed eslint globally.

tvb commented 7 years ago

I ran npm i -g eslint but yarn eslint . --fix seems to work without errors. Thanks @j4zz

lukasnagl commented 7 years ago

@nicka Check out eslint-staged with husky if you don’t know it yet. Likely makes it easier for contributors to follow project-style since you could, for example, let the project automatically run formatting steps on a precommit.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 90.0% when pulling c8e65ad4dd2dfa1b4bd0a93e46d855e5325cd39d on tvb:feature/kraken into 0a2d60aae400f74c5f3854d14dc2b0311e8b4ac6 on nicka:master.

tvb commented 7 years ago

got 2 ✅ 🎉 !

nicka commented 7 years ago

Hehe for now! I'm adding some more Jest config tomorrow since the coverage did not check for the new kraken.js

nicka commented 7 years ago

Also please update the .env.example and README.md for Kraken support.

tvb commented 7 years ago

@nicka done

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 90.0% when pulling 54917de7c141af00b4b57d37320ac3cee6de1e74 on tvb:feature/kraken into 0a2d60aae400f74c5f3854d14dc2b0311e8b4ac6 on nicka:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 90.0% when pulling 2d24870f0f60bacf2d61ee003b85dcea5db8ae3e on tvb:feature/kraken into 0a2d60aae400f74c5f3854d14dc2b0311e8b4ac6 on nicka:master.

nicka commented 7 years ago

Build is failing

lukasnagl commented 7 years ago

@tvb What’s the status on this? I do think Kraken support would be valuable.

tvb commented 7 years ago

@j4zz I moved on, but feel free to fix this PR and have @nicka include it 👍