nickabattista / IB2d

An easy to use immersed boundary method in 2D, with full implementations in MATLAB and Python that contains over 75 built-in examples, including multiple options for fiber-structure models and advection-diffusion, Boussinesq approximations, and/or artificial forcing.
GNU General Public License v3.0
164 stars 90 forks source link

Python port #1

Closed mountaindust closed 8 years ago

mountaindust commented 8 years ago

This should complete the Python port and basic testing for:

3-Element Hill Muscle is untested, and Electrophysiology is not included. Any other recent updates to the MATLAB code are also not included. It would be a good idea to further test the included examples by comparing their output in VisIt.

devangel77b commented 8 years ago

Didnt' realize there was a python port going on. Is there anything I can help with?

mountaindust commented 8 years ago

Yes! There are definitely plenty of things that could be done. Here's a quick, off the top of my head laundry list:

devangel77b commented 8 years ago

I'm familiar with Hill models and can take a stab at it if Nick wants me to; after that I can try C stuff (have done some of that too). @nickabattista

nickabattista commented 8 years ago

Hi all! That'd be great! I don't think the 3-Element Hill model was fully incorporated. I believe the forcing function was never completed. I had that set as an undergraduate project, but they had decided not to join the group.

mountaindust commented 8 years ago

OK - Well, why don't you go ahead and merge my fork into your repository @nickabattista, and then @devangel77b can work off of a new fork from your master? Unless there are concerns with the current code, I'm done working on the Python port myself for now. Of course I'm happy to be available for consultation or bug fixes! I've noted that 3-Hill is likely broken in the Python README, so there shouldn't be any confusion there if someone clones your master repository.

nickabattista commented 8 years ago

Hi Christopher - sorry that took me so long to accept. I'm going to rename some of the subfolders to separate the matlab and python code.

mountaindust commented 8 years ago

No worries. I thought about doing some reorganization myself, but in the end, I figured it's better if you do it.