search

nickbock / ElvUI_Enhanced_Again

https://www.curseforge.com/wow/addons/elvui-enhanced-again
MIT License
11 stars 13 forks source link

Equipment Set Overlay feature throwing thousands of errors on loading in, not working #142

Closed Xyrm closed 1 year ago

Xyrm commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Log in to any character
  2. Equipment Set Overlay functionality fails with the following error:
  3. 3672x ...dOns/ElvUI_Enhanced/modules/equipment/setoverlay.lua:94: attempt to call global 'GetContainerNumSlots' (a nil value) [string "@ElvUI_Enhanced/modules/equipment/setoverlay.lua"]:94: in function UpdateBagInformation' [string "@ElvUI_Enhanced/modules/equipment/setoverlay.lua"]:116: in functionToggleSettings' [string "@ElvUI_Enhanced/modules/equipment/setoverlay.lua"]:135: in function <...dOns/ElvUI_Enhanced/modules/equipment/setoverlay.lua:124> [string "@ElvUI/Core/General/Core.lua"]:1788: in function CallLoadFunc' [string "@ElvUI/Core/General/Core.lua"]:1803: in functionCallLoadedModule' [string "@ElvUI/Core/General/Core.lua"]:1829: in function InitializeModules' [string "@ElvUI/Core/General/Core.lua"]:1938: in functionInitialize' [string "@ElvUI/Core/init.lua"]:197: in function <ElvUI/Core/init.lua:196> [string "@Details/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ceDetails/Libs/AceAddon-3.0/AceAddon-3.0.lua:61> [string "@Details/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function `EnableAddon' [string "@Details/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <...ceDetails/Libs/AceAddon-3.0/AceAddon-3.0.lua:611>
  4. Seems to be thousands of errors upon logging in, but doesn't seem to increase after that. I've tried it on multiple classes (DH, DK, monk, evoker) - all have the same behavior. The exact number of errors seems to be somewhat random but usually over 3500.
  5. If I disable the Equipment - "Equipment Set Overlay" feature, there are no errors or issues with the addon.

Expected behavior No error in bugsack, and seeing sets that each item is a part of in its icon. Seems to be thousands of errors upon logging in, but doesn't seem to increase after that.

Screenshots If applicable, add screenshots to help explain your problem.

Version (please complete the following information):

Additional context Been happening since the last update, the overlays just don't work. I find knowing at a glance what set each item is a part of in my bags super helpful!

XelnorOne commented 1 year ago

I was able to get it working again by changing Line 94 in the /ElvUI_Enhanced/modules/equipment/setoverlay.lua file from

for slotID = 1, GetContainerNumSlots(bagID) do

to

for slotID = 1, C_Container.GetContainerNumSlots(bagID) do

No errors with this change anymore and sets are shown over items in bags again.

Xyrm commented 1 year ago

Yep, I can confirm this corrected the issue!