nickbock / ElvUI_Enhanced_Again

https://www.curseforge.com/wow/addons/elvui-enhanced-again
MIT License
11 stars 13 forks source link

New bug since elvui update #153

Open Disec opened 1 year ago

Disec commented 1 year ago

Seems after the most recent elvui update, your addon is breaking some other elvui addons from loading. BenikUI among others. Ive had to disable this for the time being, but I really love your addon

Moowalker commented 1 year ago

Im getting also LUA errors with the addon enable and half of the skins are not loading.

41x ElvUI/Core/General/Core.lua:379: attempt to call local 'func' (a boolean value) [string "@ElvUI/Core/General/Core.lua"]:379: in functionValueFuncCall' [string "@ElvUI/Core/General/Core.lua"]:331: in function UpdateMedia' [string "@ElvUI/Core/General/Core.lua"]:1949: in functionInitialize' [string "@ElvUI/Core/init.lua"]:222: in function <ElvUI/Core/init.lua:221>

[string "@!KalielsTracker/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...s/!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:61> [string "@!KalielsTracker/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function EnableAddon' [string "@!KalielsTracker/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <...s/!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:611> [string "=[C]"]: in functionLoadAddOn' [string "@FrameXML/UIParent.lua"]:538: in function UIParentLoadAddOn' [string "@FrameXML/UIParent.lua"]:743: in functionMajorFactions_LoadUI' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:100: in function SetUpMajorFactionList' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:93: in functionRefreshMajorFactionList' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:88: in function RefreshOverlay' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:80: in function <...sionLandingPage/Blizzard_DragonflightLandingPage.lua:76> [string "=[C]"]: in functionCreateFrame' [string "@Blizzard_ExpansionLandingPage/Blizzard_DragonflightLandingPage.lua"]:49: in function CreateOverlay' [string "@Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:63: in functionRefreshExpansionOverlay' [string "@Blizzard_ExpansionLandingPage/Blizzard_ExpansionLandingPage.lua"]:35: in function <...pansionLandingPage/Blizzard_ExpansionLandingPage.lua:33>`

Addon v.4.1.5 ElvUI v. 13.21

Loreinator commented 1 year ago

I had this issue too, it seems that as of 3.18, the structure of valueColorUpdateFuncs changed enough to break ElvUI_Enhanced. I'm not sure if this preserves the functionality of it, but it seemed to remove the errors for me: Go to the file:

ElvUI_Enhanced/modules/datatexts/range.lua

and change lines 52 and 59 to be:

local function ValueColorUpdate(_, hex, r, g, b)

E.valueColorUpdateFuncs.RangeEnhanced = ValueColorUpdate

That should make it at least follow the same new structure, but I'm unsure if the function's behaviour needs to be adjusted as well (This just changes the way it gets into the valueColorUpdateFuncs variable, and allows it to follow the new set of arguments).

Loreinator commented 1 year ago

Note from Jan 17th in the ElvUI Discord, though I'm not 100% sure what it means for the last line. Perhaps lines 55, 56, and 57 can be deleted?

I'm making a breaking change in ElvUI. This mostly will break DataTexts in edits. E.valueColorUpdateFuncs[ValueColorUpdate] = true will no longer be needed in the DataTexts ValueColorUpdate function got changed to support self as the first arg which moved hex, r, g, b over 1 slot. Which also means all of the lastPanel stuff is no longer needed.. eg: if lastPanel ~= nil then OnEvent(lastPanel) end

nickbock commented 1 year ago

Thanks for the help @Loreinator For now i've taken over your edits and look into it later on in more detail.

Merged in 4.2.0 version