nickbooties / passwordpolicy

GNU Affero General Public License v3.0
2 stars 4 forks source link

fixes for some php errors on password change (attempt) #5

Closed michag86 closed 9 years ago

michag86 commented 9 years ago

I have noticed a couple of PHP errors that occurred when I tried to change my password

If password is long enough but something other with the password is wrong, this error will be logged:

Undefined variable: error at [owncloudpath]/apps/passwordpolicy/controller/passwordpolicycontroller.php#32

This will be logged on every password change request:

Argument 2 passed to OCA\PasswordPolicy\Controller\PasswordPolicyController::__construct() must implement interface OCP\IRequest, none given, called in [owncloudpath]/apps/passwordpolicy/hooks/passwordpolicyhooks.php on line 17 and defined at [owncloudpath]/apps/passwordpolicy/controller/passwordpolicycontroller.php#13
Undefined variable: request at [owncloudpath]/apps/passwordpolicy/controller/passwordpolicycontroller.php#14
Argument 2 passed to OCP\AppFramework\Controller::__construct() must implement interface OCP\IRequest, null given, called in [owncloudpath]/apps/passwordpolicy/controller/passwordpolicycontroller.php on line 14 and defined at [owncloudpath]/lib/public/appframework/controller.php#62

If password applies to policy, this error will be logged:

Undefined index: status at [owncloudpath]/apps/passwordpolicy/hooks/passwordpolicyhooks.php#21

Most of the time I do not know exactly what I'm doing here, but these changes have corrected the error messages. So it would be good if you look, if my changes are ok.