search

nickbutcher / plaid

An Android app which provides design news & inspiration as well as being an example of implementing material design.
Apache License 2.0
16.26k stars 3.16k forks source link

Searching in Search creates an endless loop #697

Open manuelvicnt opened 5 years ago

manuelvicnt commented 5 years ago

Steps to reproduce:

  1. Open the app
  2. Click on the search icon, type something and click the keyboard's search icon
  3. The search results appear
  4. Click on the navigation bar (or word you typed before), type something else and search again.
  5. The UI is inconsistent: there's a "No results for newword" message in the background and the UI spins forever. In the app, that means that there's a endless loop in the SearchActivity + SearchViewModel
manuelvicnt commented 5 years ago

After debugging it, it seems like when you search for the second time and the SearchActivity gets new search results (L112), the InfiniteScrollListener gets triggered (L161) and calls loadMore again.

manuelvicnt commented 5 years ago

Happens when connectivity is slow so that makes it flaky