Using singleton design pattern for repositories

[mahdiyar-oraei]

Why are you using singleton design pattern and @FeatureScope together to create instances of repositories instead only marking them as @FeatureScope?

companion object {
        @Volatile
        private var INSTANCE: ShotsRepository? = null

        fun getInstance(remoteDataSource: SearchRemoteDataSource): ShotsRepository {
            return INSTANCE ?: synchronized(this) {
                INSTANCE ?: ShotsRepository(remoteDataSource)
                    .also { INSTANCE = it }
            }
        }
}

    @Provides
    @FeatureScope
    fun provideShotsRepository(remoteDataSource: SearchRemoteDataSource) =
        ShotsRepository.getInstance(remoteDataSource)

[guelo]

Good observation. I don't understand the use of FeatureScope at all since the components are created in the inject methods which are called from each Activity's onCreate, which means they are discarded on rotation. Since injections will only occur once what is the point of scopes?