[801] Fix HomeToolbar popupTheme in non-night mode - Githubissues

nickbutcher / plaid

An Android app which provides design news & inspiration as well as being an example of implementing material design.

Apache License 2.0

16.26k stars 3.16k forks source link

[801] Fix HomeToolbar popupTheme in non-night mode #820

Closed ataulm closed 4 years ago

ataulm commented 4 years ago

:loudspeaker: Type of change

[x] Bugfix
[ ] New feature
[ ] Enhancement
[ ] Refactoring

:scroll: Description

materialThemeOverlay doesn't work with AppCompatToolbar
since the style is being set explicitly (activity_home), we can use android:theme, and this will be applied as an overlay
the popup menu is already taking colorSurface correctly, but not sure why it's not setting the text accordingly. Overriding textColorPrimary to colorOnSurface fixes it, while applying it in a small scope (only to the HomeToolbar's popupTheme) means we won't goof anything else up

:bulb: Motivation and Context

Fixes #801 - PopMenu has always white text even when in light mode

:green_heart: How did you test it?

Visually - see screenshots

:pencil: Checklist

[x] I ran ./gradlew spotlessApply before submitting the PR
[x] I reviewed submitted code
[ ] I added tests to verify changes
[ ] All tests passing

:crystal_ball: Next steps

Wait for comments

:camera_flash: Screenshots / GIFs

Before (dark mode)	After

Before (light mode)	After

pfmaggi commented 4 years ago

Thanks for the contribution and sorry for the delay reviewing it!

ataulm commented 4 years ago

No worries, thanks for the review ☺️