nickcam / AnimatedEnvironmentLayer

A custom arcgis js api layer to display GRIB data formatted as json as animated particles on a canvas
https://animatedenvironmentlayer.azurewebsites.net/index.html
44 stars 10 forks source link

Wind animation is not visible on full screen #15

Closed sanketkardile closed 5 days ago

sanketkardile commented 2 years ago

Wind layer is not rendering on full screen. I am trying to solve this issue from long time. Please help me with this @nickcam . Thank you.

wy201707 commented 1 year ago

I also encountered this problem, did you solve it? Can you tell me how?

nickcam commented 1 year ago

Hi guys, sorry I haven't really been paying attention to this repo for a while. When I get a chance I'll take a look at this. I've just looked at my demo page and it's displaying correctly over the full screen for me. Do you get the same behaviour when viewing here?
http://animatedenvironmentlayer.azurewebsites.net/index.html

If it's busted on that page for you, are there any errors in the js console? What browser are you using?

wy201707 commented 1 year ago

Thank you for taking the time to reply me!

I opened your link with Chrome, edge, firefox, but still found misalignment and scaling. There are some errors and warnings, I have attached a picture (Figure 1-Figure 4, only screenshots of the wave data source in Australia, because it can show dislocation and scaling at the same time), maybe you can take a look.

It doesn’t seem to be a problem with the algorithm, it’s just that the offset and scaling appear when the screen is displayed (Figure 4, chrome, it’s so strange! Here, when the mouse points to the picture, the direction and speed are displayed in the lower left corner, but not on the drawing board Line? When the mouse stops on the Australian territory, the direction and angle display n/a, which is in line with the algorithm logic, but the picture is obviously misplaced)

I'm confused, and I don't even know which direction to think in order to solve the bug, please help me to judge whether my direction is correct?

New ideas: The problem now is to display the canvas image on a high-resolution screen. After the canvas drawing board is enlarged, do we still need corresponding graphics? (But the particle animation is completely messed up. I didn't expect it, and I can't understand it. It seems that it is unwise to think that it is only related to window.devicePixelRatio)

fig1(edge)

fig 2 chrome(not my computer)

fig3 firefox

fig4 chrome

------------------ 原始邮件 ------------------ 发件人: "nickcam/AnimatedEnvironmentLayer" @.>; 发送时间: 2023年3月28日(星期二) 上午6:24 @.>; @.**@.>; 主题: Re: [nickcam/AnimatedEnvironmentLayer] Wind animation is not visible on full screen (Issue #15)

Hi guys, sorry I haven't really been paying attention to this repo for a while. When I get a chance I'll take a look at this. I've just looked at my demo page and it's displaying correctly over the full screen for me. Do you get the same behaviour when viewing here? http://animatedenvironmentlayer.azurewebsites.net/index.html

If it's busted on that page for you, are there any errors in the js console? What browser are you using?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

wy201707 commented 1 year ago

Thank you for taking the time to reply me!

I opened your link with Chrome, edge, firefox, but still found misalignment and scaling. There are some errors and warnings, I have attached a picture (Figure 1-Figure 4, only screenshots of the wave data source in Australia, because it can show dislocation and scaling at the same time), maybe you can take a look.

It doesn’t seem to be a problem with the algorithm, it’s just that the offset and scaling appear when the screen is displayed (Figure 4, chrome, it’s so strange! Here, when the mouse points to the picture, the direction and speed are displayed in the lower left corner, but not on the drawing board Line? When the mouse stops on the Australian territory, the direction and angle display n/a, which is in line with the algorithm logic, but the picture is obviously misplaced)

I'm confused, and I don't even know which direction to think in order to solve the bug, please help me to judge whether my direction is correct?

New ideas: The problem now is to display the canvas image on a high-resolution screen. After the canvas drawing board is enlarged, do we still need corresponding graphics? (But the particle animation is completely messed up. I didn't expect it, and I can't understand it. It seems that it is unwise to think that it is only related to window.devicePixelRatio)

fig1(edge)

fig 2 chrome(not my computer)

fig3 firefox

fig4 chrome

------------------ 原始邮件 ------------------ 发件人: "nickcam/AnimatedEnvironmentLayer" @.>; 发送时间: 2023年3月28日(星期二) 上午6:24 @.>; @.**@.>; 主题: Re: [nickcam/AnimatedEnvironmentLayer] Wind animation is not visible on full screen (Issue #15)

Hi guys, sorry I haven't really been paying attention to this repo for a while. When I get a chance I'll take a look at this. I've just looked at my demo page and it's displaying correctly over the full screen for me. Do you get the same behaviour when viewing here? http://animatedenvironmentlayer.azurewebsites.net/index.html

If it's busted on that page for you, are there any errors in the js console? What browser are you using?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

sanketkardile commented 1 year ago

Yes I solved the problem

On Fri, 17 Mar, 2023, 2:08 pm ArcGIS_vue_express, @.***> wrote:

I also encountered this problem, did you solve it? Can you tell me how?

— Reply to this email directly, view it on GitHub https://github.com/nickcam/AnimatedEnvironmentLayer/issues/15#issuecomment-1473403980, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJ6LAZA4QHG34U52336G3LW4QPH3ANCNFSM54Y2JYQA . You are receiving this because you authored the thread.Message ID: @.***>

wy201707 commented 1 year ago

Yes I solved the problem

Can you tell me how to do it? Maybe provide some solutions or related codes? I will be very grateful for your help (Look at my expectant eyes.jpg)

wy201707 commented 1 year ago

can you tell me the solution? I'm still stuck on this issue, hope some blog link or reference code/project? Thank you very much for your reply (It seems that the last reply has not been sent to your mailbox, I am not familiar with the reply operation of github) I thought it was a problem with window.devicePixelRatio before, but it was completely messed up when it was not an integer. I don’t understand the project and invert functions, so I can’t fix it for a while

------------------ 原始邮件 ------------------ 发件人: "nickcam/AnimatedEnvironmentLayer" @.>; 发送时间: 2023年3月28日(星期二) 中午1:26 @.>; @.**@.>; 主题: Re: [nickcam/AnimatedEnvironmentLayer] Wind animation is not visible on full screen (Issue #15)

Yes I solved the problem

On Fri, 17 Mar, 2023, 2:08 pm ArcGIS_vue_express, @.***> wrote:

> I also encountered this problem, did you solve it? Can you tell me how? > > — > Reply to this email directly, view it on GitHub > <https://github.com/nickcam/AnimatedEnvironmentLayer/issues/15#issuecomment-1473403980&gt;, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AIJ6LAZA4QHG34U52336G3LW4QPH3ANCNFSM54Y2JYQA&gt; > . > You are receiving this because you authored the thread.Message ID: > @.***> >

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

nickcam commented 1 year ago

I was able to replicate the problem using Chrome Dev tools and updating the devicePixelRatio. I've just committed a fix so that the canvas draw space will size correctly based on the current window.devicePixelRatio of the screen.

Grab the latest and let me know how you go.