More testing - Githubissues

nickcharlton / administrate-field-nested_has_many

A plugin for nested has_many forms in Administrate

MIT License

59 stars 99 forks source link

More testing #43

Closed pablobm closed 4 years ago

pablobm commented 4 years ago

(Same as https://github.com/nickcharlton/administrate-field-nested_has_many/pull/40 and https://github.com/nickcharlton/administrate-field-nested_has_many/pull/41).

While I try diagnose something else, this PR adds two helps to development:

Adds a root route, so that the administratre-0.13 appraisal passes tests, which are breaking currently.
Tests the "edit" and "update" cases, which are test-less at the moment.

pablobm commented 4 years ago

So I went and had a look at my CircleCI config. Had to configure stuff, and now it's running over there at my account. Still refuses to appear here.

nickcharlton commented 4 years ago

I'll open a support ticket with Circle and see what's going on.

nickcharlton commented 4 years ago

So it turns out that this option in the Advanced section of the CircleCI config is to blame, as it wasn't enabled:

Screenshot 2020-06-03 at 10 16 23

Apparently you also have to ensure you're not following the fork on your own CircleCI dashboard, but presumably you have to actively do something to end up in that situation.

pablobm commented 4 years ago

I had a look at my CircleCI config. I think was I indeed following my fork instead of the upstream repo. Perhaps I did that when trying to fix the situation? I can't remember. I have corrected it now. Let's see if I can get this to run now...

pablobm commented 4 years ago

It works now! :tada: