search

nickcharlton / administrate-field-nested_has_many

A plugin for nested has_many forms in Administrate
MIT License
59 stars 99 forks source link

Support administrate v0.20 #66

Closed trevorrjohn closed 10 months ago

trevorrjohn commented 10 months ago

Fixes issue described in https://github.com/nickcharlton/administrate-field-nested_has_many/issues/65

Maybe not the best fix as it just gets rid of the grouping. So appreciate any feedback on this one.

trevorrjohn commented 10 months ago

@nickcharlton sorry I upgraded ruby in the PR as well along with some of the dependencies. I can spend some time to try to revert that, but if you're okay with it then it's never bad to be running the latest version.

nickcharlton commented 10 months ago

No worries! I appreciate the help more than I'm concerned about picking out bits myself to split them out if I decide to!

nickcharlton commented 10 months ago

I've pulled out everything which wasn't directly related to this change (and perhaps there's more, but this trimmed it down a lot already). I wanted to do a release before getting to this, so I did a lot of housekeeping first and so this should make it easier to work on this.

trevorrjohn commented 10 months ago

@nickcharlton any thoughts on this solution? The existing tests were failing so I didn't feel like I needed to add any.

nickcharlton commented 9 months ago

@trevorrjohn, sorry, I've been trying to get v1.0.0.beta1 of Administrate out the door before I run out of time 😅. Did you mean to close this?

I think it's probably ready to go, like as you say if the existing tests were failing we're good to go.

trevorrjohn commented 9 months ago

Oops no I don’t. I’ll reopen later today.

On Thu, Feb 8, 2024 at 06:46 Nick Charlton @.***> wrote:

@trevorrjohn https://github.com/trevorrjohn, sorry, I've been trying to get v1.0.0.beta1 of Administrate https://github.com/thoughtbot/administrate/releases/tag/v1.0.0.beta1 out the door before I run out of time 😅. Did you mean to close this?

I think it's probably ready to go, like as you say if the existing tests were failing we're good to go.

— Reply to this email directly, view it on GitHub https://github.com/nickcharlton/administrate-field-nested_has_many/pull/66#issuecomment-1933938654, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFEQLXDJV76VIBUOQCVPC3YSS3JHAVCNFSM6AAAAABCHT3ES6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTHEZTQNRVGQ . You are receiving this because you were mentioned.Message ID: <nickcharlton/administrate-field-nested_has_many/pull/66/c1933938654@ github.com>