HotelDon
commented
7 years ago Not sure what's going wrong with the tests in Travis - it looks like all the web browser tests error out before they even start. Am I missing something?
Closed HotelDon closed 7 years ago
HotelDon
commented
7 years ago Not sure what's going wrong with the tests in Travis - it looks like all the web browser tests error out before they even start. Am I missing something?
nickcmaynard
commented
7 years ago Please rebase on master to grab the JWT changes - that should allow the PR validation to proceed.
I'd like to see the sample test suite updated to include the draft-06 and experimental samples you've created.
nickcmaynard
commented
7 years ago @HotelDon This is looking good generally - I'll do a full review soon. Thank you for the contribution!
nickcmaynard
commented
7 years ago This is strange - I thought this would have the .travis.yml changes from master given I updated this PR from master... but it's not working.
Additionally, I've screwed something else up with the service worker changes I've made elsewhere.
Please hold off trying to fix this - I'll get master into a good state, then ask you to rebase.
Apologies.
nickcmaynard
commented
7 years ago OK - on retesting, I think master is OK after all. Please can you rebase? After that, let's take a look.
The code is mostly the same as I wrote it a few months ago, with only a few changes based on things that were moved around between then and now, along with cleaning up some text. I haven't added any tests, as it didn't seem like adding draft-06 and Experimental meaningfully impacted test coverage. I did run the existing tests to make sure I didn't break anything, and everything went fine until it tried to open Firefox and it borked itself - I think that was just a case of Windows being Windows, but I haven't figured out how to fix it yet. Let me know if you run into any problems with it and I'll see what I can do.