Link to the HTTPS versions of the sites

nickcmaynard / jsonschemalint

JSON Schema Lint. Like you I'm busy, so pull requests will get merged quicker than feature requests are implemented.

https://jsonschemalint.com

MIT License

80 stars 31 forks source link

Link to the HTTPS versions of the sites #50

Closed peternewman closed 5 years ago

peternewman commented 5 years ago

I'd hoped to make these hyperlinks too but from a quick test it didn't seem to work, is it as simple as changing them to ng-bind-html in https://github.com/nickcmaynard/jsonschemalint/blob/5a4dfe9377b7e04b695fd137c9d3bec826b24f78/src/components/validation-messages.html#L16 or will bad things happen when its trying to return some JSON or similar as a message?

nickcmaynard commented 5 years ago

This looks good, thanks Peter. Have you tried making the change you suggest? I'll hold off merging until you're happy you're done.

peternewman commented 5 years ago

I was going to say I think it works @nickcmaynard I haven't tested it as much as I should and I couldn't find the Sauce Labs link to look at the videos either.

peternewman commented 5 years ago

Looks to work in live too. Do you want target=_blank @nickcmaynard ?

nickcmaynard commented 5 years ago

Please - a new PR, please!