search

nickczh / pe

0 stars 0 forks source link

Groceries can be added with very huge expiry date #9

Open nickczh opened 2 months ago

nickczh commented 2 months ago

After adding the expiry date, I checked it with listexp:

image.png

nus-pe-bot commented 2 months ago

Team's Response

i think some of the groceries can last forever, e.g wine and dry fruits. But we will consider to add the function in future.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

No limit to date of grocery

Input typed in

  1. add apple
  2. 2099
  3. 01
  4. 01

expected output

exception or warning for invalid date

actual output

input was accepted

Screenshots

image.png

[original: nus-cs2113-AY2324S2/pe-interim#570] [original labels: type.FeatureFlaw severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

i think some of the groceries can last forever, e.g wine and dry fruits. But we will consider to add the function in future.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** The severity for this issue should not be very low. As explained in the CS2113T website, very low severity serves more towards documentation purposes and other minor reasons. For this issue however, it has got to do with setting a limit for the expiration date, which should have an expected severity of at least low. As you have explained and I understand that there are some groceries with very long expiration date, accepting a date with year 9999999 is not reliable. This can be improved be limited the year set to 9999. Such exception and input handling is also a good software practice. Therefore, the severity of this issue should not be very low, but low instead. This is because it relates to handling inputs which impacts the features and the way it is stored in your software.