search

nickdeis / eslint-plugin-no-secrets

An eslint plugin to find strings that might be secrets/credentials
MIT License
137 stars 5 forks source link

does this library support ESLint 7? #10

Closed dimitropoulos closed 4 years ago

dimitropoulos commented 4 years ago

once https://github.com/typescript-eslint/typescript-eslint/releases/tag/v3.0.0-alpha.23 merges, I'll be testing it myself, but I just thought I'd drop a friendly note that probably people will be inquiring here as to whether ESLint 7 is supported soon.

It may very well be already supported! There weren't a ton of breaking changes in ESLint 7 or anything. If so, it'd be nice to say that ESLint 7 is supported on the main README

nickdeis commented 4 years ago

Hey @dimitropoulos, I just saw that a week ago. Thanks for the reminder and letting me know users of this library will be upgrading. I'll see if I can add it to the testing suite. I'll close this when it's done (probably this week).

If so, it'd be nice to say that ESLint 7 is supported on the main README That's a fantastic idea and something I wouldn't of thought of.

Best, Nick

nickdeis commented 4 years ago

Hey @dimitropoulos, Just added eslint 7 testing to the unit tests. Thank you for your suggestion. Best, Nick

dimitropoulos commented 4 years ago

great! just in time! typescript-eslint 3 just released!