continuous integration - Githubissues

nickdeis / eslint-plugin-no-secrets

An eslint plugin to find strings that might be secrets/credentials

MIT License

127 stars 4 forks source link

continuous integration #2

Closed oprogramador closed 4 years ago

oprogramador commented 4 years ago

Could you add a continuous integration in order to check easily the tests status? E.g. TravisCI is reliable and free for Open Source.

nickdeis commented 4 years ago

Hey Pitor, Thank you for your suggestion and thank you for helping me make this project better. I'll try to look into that sometime this week hopefully. Cheers, Nick

nickdeis commented 4 years ago

Hey @oprogramador, Still moving, but I borrowed a friends computer to get continuous integration enabled on this repo. Let me know if there is anything else I could add. I'll leave this ticket a opened for a few more days if you have feedback. Thank You! Nick

oprogramador commented 4 years ago

I’m developing my separate fork because:

I don’t need many of your options
maybe I’ll need some yet new options so it’ll be easier to manage them
I don’t like the way how your tests are written

nickdeis commented 4 years ago

@oprogramador, I agree with the last point. ESLint's test suite is very awkward. Do you have a better solution in mind? Once I find my laptop charger in this pile of boxes, I still might implement some of your suggested features because they are really good ideas!

oprogramador commented 4 years ago

I'd like to have a mocha suite with many its. There could be a separate file testing the entropy calculation for a given word and a separate file testing splitting a string into words by various options.

nickdeis commented 4 years ago

Just started using mocha's test suite for the new JSON support I added. Probably will continue adding more tests in this format. It's a little slower but the return messages are a lot easier to use.