nickdesaulniers / fxos-irc

IRC client for FxOS (and now desktop FF)
GNU General Public License v3.0
38 stars 13 forks source link

i18n: Mangles Unicode (non-Latin-1 I suppose) characters #30

Closed mcepl closed 11 years ago

mcepl commented 11 years ago

29 is nice problem to have, but I think more urgent (particularly for users like me who try to use Firesea IRC in Czech) is that when I enter to the phone:

kasal, opalka: někdo dnes na oběd k Dobré myšlence? I get in xchat (on Linux, where I am 100% certain UTF-8 encoding in IRC works perfectly) ![firesea-irc-bug](https://f.cloud.github.com/assets/198999/1267966/31037c8e-2cd2-11e3-9112-24d20b972053.png)
nickdesaulniers commented 11 years ago

If I paste někdo dnes na oběd k Dobré myšlence? into Firesea IRC, it's logged correctly, but not transferred correctly. Hopefully this isn't an underlying bug in node-irc. I get a warning in Colloquy of an "incomplete encoding" and it prints nkdo dnes na obd k Dobré myalence? in Colloquy.

nickdesaulniers commented 11 years ago

This is not an issue with the underlying node-irc library.

irc = require 'irc'
client = new irc.Client 'irc.mozilla.org', 'testcase',
  autoConnect: false

client.connect ->
  client.join '#testclient', ->
    client.say '#testclient', 'někdo dnes na oběd k Dobré myšlence?'
    client.disconnect()

^ works.

nickdesaulniers commented 11 years ago

If I log the string immediately before calling tcpSocketInstance.send, it's fine. On the receiving end, it's not.

nickdesaulniers commented 11 years ago

Possibly related

nickdesaulniers commented 11 years ago

Possible solutions: