search

nickdesaulniers / fxos-irc

IRC client for FxOS (and now desktop FF)
GNU General Public License v3.0
38 stars 13 forks source link

User tab #50

Closed nickdesaulniers closed 11 years ago

nickdesaulniers commented 11 years ago

review? @louisstow

louisstow commented 11 years ago

What's the license for the icons?

nickdesaulniers commented 11 years ago

Creative Commons, I listed the authors in my.js. There's probably a more professional way to attribute their work.

nickdesaulniers commented 11 years ago

http://findicons.com/icon/445798/close_square?id=445963 and http://findicons.com/icon/468256/usergroup_search?id=468610

nickdesaulniers commented 11 years ago

Hmm... I'm seeing major performance regressions testing this on device when joining many rooms with many users. ex: developers, rust, openwebapps. I think it's because I'm using addText and it's scanning every single nick, which is unnecessary.

nickdesaulniers commented 11 years ago

review? @louisstow