nickdesaulniers / fxos-irc

IRC client for FxOS (and now desktop FF)
GNU General Public License v3.0
38 stars 13 forks source link

move the tabs to the top, fixes #54 #55

Closed mikehenrty closed 10 years ago

nickdesaulniers commented 11 years ago

@mikehenrty , I like this pull request, an Imma let you finish, but...

I really don't like the Setup tab at the top when no tabs are connected to. I think we should find a way to hide it when there are no visible tabs.

Would you:

The third idea is the simplest, and most boring. The others require more work and knowledge of Brick's APIs (which are simple). document.getElementById('tabbar').tabs.length

Also, add your name to the AUTHORS file, alphabetical by first name.

nickdesaulniers commented 10 years ago

Closed in favor of https://github.com/nickdesaulniers/fxos-irc/commit/16f016b3487cad83b2aaeec6b48f18b37c4d44fc