nickdesaulniers / fxos-irc

IRC client for FxOS (and now desktop FF)
GNU General Public License v3.0
38 stars 13 forks source link

Allow specifying PASS or SASL authentication (#77) #81

Closed errietta closed 9 years ago

errietta commented 9 years ago

This allows clients to connect to password-protected servers that require PASS or SASL authentication to connect to (e.g.: bouncers, and sometimes IRC networks require SASL from mobile connections to prevent abuse)

nickdesaulniers commented 9 years ago

Cool thanks for the PR. Just fix up those 2 small things and it's good to go!

errietta commented 9 years ago

@nickdesaulniers fixed, please see :D

nickdesaulniers commented 9 years ago

Thanks Errietta, I'm falling behind on code reviews this week; I'm in Singapore teaching a university class. I'll have some more time next week and during the holidays, but this week reviews will be slow.

nickdesaulniers commented 9 years ago

Looking good. I think the string Password (used for PASS and SASL).: is too long, and it's not immediately clear if it's the channel password or the host password. Also, it's not strictly necessary to connect to most irc servers. I think we should either move the field to be right after Host and short the string to either Password or Host Password, or move it into the settings (what appears after the gear icon is clicked on). What are your thoughts @errietta ?

errietta commented 9 years ago

@nickdesaulniers how about now :)

nickdesaulniers commented 9 years ago

Thanks Errietta, nice work