search

nickdesaulniers / fxos-irc

IRC client for FxOS (and now desktop FF)
GNU General Public License v3.0
37 stars 13 forks source link

Forced JOIN woes #82

Closed errietta closed 9 years ago

errietta commented 9 years ago

So @nickdesaulniers - I wanted your opinion on this. I want to use this with my bouncer. When I connect to it, it JOIN's me to a bunch of channels. Currently, firesea only creates a tab when it itself JOIN's your list of channels on connect, meaning that if a JOIN is otherwise sent to the client (due to the bouncer force-JOINing the client to ALL its channels on connect, services auto-join or some other form of being force-JOINed) firesea won't create a tab for it. A simple solution is to move the join-handling code to an event listener, like http://errietta.me/paste/view.php?id=543 ( still needs work, but I wanted to know if you think that's sensible ). It won't break the initial channel join, either, and will handle force-JOINs at any point.

nickdesaulniers commented 9 years ago

That's a simple and elegant solution. What's the program you used to share the diff? It's neat!

errietta commented 9 years ago

The diff itself is git format-patch, the pastebin is luminous syntax hilighting + bootstrap, my own code. (I should rewrite it and open source it at some point!)

errietta commented 9 years ago

@nickdesaulniers R?