search

nickdesaulniers / node-nanomsg

Node.js binding for nanomsg
MIT License
402 stars 70 forks source link

unix IPC fix: a new-ish define flag automatically cleans up descriptor #192

Closed reqshark closed 6 years ago

reqshark commented 6 years ago

Fixes #191

@art32, we always cleaned up IPC sockets on unixes manually before, but we should have been using this feature since beta-9

An honorable mention/ref for @Snaipe and @gdamore for adding this handy way to clean up IPC sockets from the NN_HAVE_UNIX_SOCKETS define. cheers! thanks guys! 🍻

Note: for a Node.JS binding we specify library defines auto-populated during OS detection step of a regular build/compile... those need to be manually spelled out in .gyp defines array

refs: • https://github.com/nanomsg/nanomsg/commit/c08f6f98dc72b89dd53989f97f01943f63d1a936#diff-b0d243dce80d72524ecf035d9c987bbc

• https://github.com/nanomsg/nanomsg/issues/666

@nickdesaulniers, review?

nickdesaulniers commented 6 years ago

nice work Bent! :wolf: :package:

nickdesaulniers commented 6 years ago

did Travis run for this PR?

nickdesaulniers commented 6 years ago

oh, yeah, nvm