search

nickdesaulniers / node-nanomsg

Node.js binding for nanomsg
MIT License
402 stars 70 forks source link

update nan@2.8 #194

Closed reqshark closed 6 years ago

reqshark commented 6 years ago

this PR updates NAN and gets rid of this deprecation message on install:

../node_modules/nan/nan_maybe_43_inl.h:112:15: warning: 'ForceSet' is deprecated [-Wdeprecated-declarations]
  return obj->ForceSet(isolate->GetCurrentContext(), key, value, attribs);
              ^
/Users/bent/.node-gyp/9.4.0/include/node/v8.h:3114:3: note: 'ForceSet' has been explicitly marked deprecated here
  V8_DEPRECATED("Use CreateDataProperty / DefineOwnProperty",
  ^
/Users/bent/.node-gyp/9.4.0/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
1 warning generated.
  CXX(target) Release/obj.target/node_nanomsg/src/poll_ctx.o
In file included from ../src/poll_ctx.cc:2:
In file included from ../src/poll_ctx.h:3:
In file included from ../node_modules/nan/nan.h:192:
../node_modules/nan/nan_maybe_43_inl.h:112:15: warning: 'ForceSet' is deprecated [-Wdeprecated-declarations]
  return obj->ForceSet(isolate->GetCurrentContext(), key, value, attribs);
              ^
/Users/bent/.node-gyp/9.4.0/include/node/v8.h:3114:3: note: 'ForceSet' has been explicitly marked deprecated here
  V8_DEPRECATED("Use CreateDataProperty / DefineOwnProperty",
  ^
/Users/bent/.node-gyp/9.4.0/include/node/v8config.h:321:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated))
                            ^
1 warning generated.
  SOLINK_MODULE(target) Release/node_nanomsg.node

Also i think we might have to drop node v0.12 and v0.10 for this

@nickdesaulniers,

review?

nickdesaulniers commented 6 years ago

lol what's the point of nan if we don't get the backwards compat?

reqshark commented 6 years ago

ok well travis says nan 2.8 is still backwards compat, so i added those two versions back

I got unrelated error about asan trying to compile those two versions on my mac...

so ya that's not nan's fault

nickdesaulniers commented 6 years ago

LGTM thanks Bent! :beer: :football:

reqshark commented 6 years ago

my pleasure Nick!

just bumped PATCH so npm i nanomsg@4.0.2 looks nice and clean again 🚀 🐢 🍻