search

nickdesaulniers / node-nanomsg

Node.js binding for nanomsg
MIT License
402 stars 70 forks source link

Cpp rewrite #218

Closed nickdesaulniers closed 5 years ago

nickdesaulniers commented 5 years ago

mostly stylistic changes other than the meat in src/poll_ctx.cc.

reqshark commented 5 years ago

@nickdesaulniers, this looks good, I like the style stuff. As for the pollctxing, let me poke around at this, give the new code to a long-running process just to make sure memory is nice and flat etc etc

nickdesaulniers commented 5 years ago

I honestly wish I had written a memory leak test the last time we looked into it a few years ago. :(