fix for node.js versions > 13

nickdesaulniers / node-nanomsg

Node.js binding for nanomsg

MIT License

402 stars 70 forks source link

fix for node.js versions > 13 #227

Closed den1zk closed 2 years ago

den1zk commented 2 years ago

PollCtx::UnwrapPointer was causing crashes in Node.js versions greater than 13.x.

inlife commented 2 years ago

Confirming that the patch works! 👍 Tested on macOS 11.6, Apple M1, Node: v15.12.0

nickdesaulniers commented 2 years ago

Thanks for the PR. What's going on with the history in this branch? Can you drop the reverts/deletes, and perhaps break these up in to separate PRs rather than 1 with many commits?

den1zk commented 2 years ago

Hi, reverts and deletes are for "npm install"ing the repository directly. I will create a new PR for the patch.

den1zk commented 2 years ago

A new PR will be opened just for demonstrating the difference.