search

nickdesaulniers / node-nanomsg

Node.js binding for nanomsg
MIT License
402 stars 70 forks source link

Support Electron > 14 #233

Closed Bartel-C8 closed 2 years ago

Bartel-C8 commented 2 years ago

Use updated NAN_MODULE_WORKER_ENABLED macro from nan (which takes care of nodejs versioning) https://github.com/nodejs/nan/commit/b058fb047d18a58250e66ae831444441c1f2ac7a

See electron deprecation issue: https://github.com/electron/electron/issues/18397

Solves https://github.com/nickdesaulniers/node-nanomsg/issues/224

Bartel-C8 commented 2 years ago

@nickdesaulniers : could you review it please? As nan has been recently upgraded, this should cause no problems.

nickdesaulniers commented 2 years ago

Sorry for the delay; have been sick with Covid; still am.

Do we need to upgrade the version of NAN used, too? https://github.com/nickdesaulniers/node-nanomsg/blob/f339119585797bebebb17fc02028db61904ba783/package.json#L8

Bartel-C8 commented 2 years ago

Take care!

No, no upgrade of nan is needed as 2.15.0 and above contains the mentioned patch which is needed: https://github.com/nodejs/nan/commit/b058fb047d18a58250e66ae831444441c1f2ac7a

nickdesaulniers commented 2 years ago

thanks for the patch, I will work on publishing a new release tonight

nickdesaulniers commented 2 years ago

published https://www.npmjs.com/package/nanomsg/v/4.2.1