nickdesaulniers / node-rtc-peer-connection

[BROKEN/UNMAINTAINED] RTCPeerConnection for Node.js
Other
154 stars 17 forks source link

Invalid description, no fingerprint attribute #26

Closed nickdesaulniers closed 8 years ago

nickdesaulniers commented 8 years ago

another thing missing from the SDP, after #25

nickdesaulniers commented 8 years ago

looks like FF uses sha-256 with a unique fingerprint (so unique cert?) for every call

nickdesaulniers commented 8 years ago

I don't think FF even checks this. It looks like it just checks for attribute presence and recognition of hashing algorithm: https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp#1552-1559

nickdesaulniers commented 8 years ago

nope it checks https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/sdp/SipccSdpAttributeList.cpp#254

nickdesaulniers commented 8 years ago

https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#797-807