Add support for overriding the number of generated rows in DataTables

nickdodd79 / AutoBogus

A C# library complementing the Bogus generator by adding auto creation and population capabilities.

MIT License

431 stars 50 forks source link

Add support for overriding the number of generated rows in DataTables #55

Closed logiclrd closed 3 years ago

logiclrd commented 3 years ago

This PR:

Adds new configuration method .WithDataTableRowCount to the config builder interface.
Implements it in the config object.
Adds unit tests that can only pass when it is properly implemented.
Updates the DataTable and DataSet generators to implement it, making the tests pass.
Includes a corresponding update to the documented API surface in AutoBogus.xml.

logiclrd commented 3 years ago

Hello @nickdodd79 :-) Do you have a bit of time to check out the four additional PRs that I created in response to using the new System.Data functionality in our codebase? (This being one of them :-) )

logiclrd commented 3 years ago

Just another ping @nickdodd79, we are actively using these features through a private build on our internal artefacts server, and it would be nice to be able to go back to the mainline, if these changes are agreeable to you. :-)

nickdodd79 commented 3 years ago

Hey @logiclrd

Apologies for the delay. I was out of action for a bit and have been slowly getting back into things. Unfortunately a couple of other project have taken my full focus, meaning I have kept tabs on this one - plus my GitHub notifications seemed to have stopped.

Nick.

logiclrd commented 3 years ago

Welcome back, in that case! :-) Hope everything's okay.