nickdodd79 / vscode-gulptasks

A gulp task visualization and execution extension for Visual Studio Code
MIT License
7 stars 6 forks source link

Work with newer gulp-cli 2.0.0? #7

Closed bdelaney closed 6 years ago

bdelaney commented 6 years ago

Just installed in project with gulpfile and it locates that fine. But then hangs on 'loading gulp tasks ...'

nickdodd79 commented 6 years ago

Hi @bdelaney,

Thanks for the heads up, I'll take a look and put a fix in.

Nick.

bdelaney commented 6 years ago

I did test against regular Gulp client in same project and the extension works fine. I'm not sure it is an issue for the extension though. By reading some issues on the gulp-cli repo I found that the gulp-cli install is not supposed to need the old gulp package, and yet, it fails in a local project with this error if the old gulp package is not installed: Local gulp not found Try running: npm install gulp It's odd because some gulp commands work, but others give this error. So I npm install the old gulp client locally in the project... Voila! Your extension works fine and loads Gulp tasks.

Very odd behavior by the new gulp-cli which does not indicate any dependency on old gulp package.... I submitted as an issue at GitHub repo for gulp-cli project.

nickdodd79 commented 6 years ago

Hi @bdelaney,

I have just spent some time trying to understand why the issue was occurring and reached the same conclusion. It seems that there needs to a local gulp install for the tasks to be discovered.

The extension was hanging as such, but swallowing an empty result which looked like nothing was happening. It executes 'gulp --tasks-simple' which was returning an empty string and not display a message correctly. I have changed this slightly so at least a message is displayed.

Unfortunately though I don't think I can make any changes to fix the gulp-cli you found, other than installing gulp local to the gulpfile.js project.

Nick.

bdelaney commented 6 years ago

Thanks Nick. Hope others find this info useful.