nickejanssen / WOM

GNU General Public License v2.0
1 stars 0 forks source link

Music Page #1

Closed nickejanssen closed 8 years ago

nickejanssen commented 8 years ago

Summary: Build music page so that record holders, and general users can listen to them music, download the album/stems.

We will be using:

Tasks:

PAMulligan commented 8 years ago

I've configured the application, although I don't know if you're storing your secrets in an .env file or not. Obviously, I can't access your S3 account, so I'm going to move ahead to setting up the music player.

nickejanssen commented 8 years ago

I was, but I took them out when I was having issues. I'll add them again so you will have access. I attempted to install the plugin, but was only getting the background of the player. I double checked through the css and html that I was referencing everything correctly and it looked fine. Might be that I didnt add the assets in the pipeline appropriately. Let me know if you figure it out.

Thanks again for contributing, it makes a huge difference.r

nickejanssen commented 8 years ago

I added the keys to the environment. They can be accessed using:

ENV["ACCESS_KEY_ID"] ENV["SECRET_ACCESS_KEY"] ENV["BUCKET"]

PAMulligan commented 8 years ago

Can you add your region in the .env file under AWS_REGION?

nickejanssen commented 8 years ago

I added it. You should be good to go. Let me know if you have any issues.

PAMulligan commented 8 years ago

I don't think I can access the S3 bucket without the .env file being part of the repo. I have to set the region manually, and while I haven't tried to implement video files from the bucket yet, my thought is that I won't be able to login. I think the simplest workaround is just to use my own bucket, so I'm going to take this test mp4 and upload it to my AWS.

I have the player loaded on the page, but when I try to play the video, the link appears to be broken. Is this the issue you were running into?

nickejanssen commented 8 years ago

It should only be audio files that are needed. You might be using the womAnimation.mp4 file that I have in the assets. I added a couple songs to assets/audio that you can use, 01_Raise_Your_Voices.mp3 and 02_Word_of_Mouth.mp3. The issue I was running into, was that none of the components of the music player would load except for the background. If you got to the music page, you can see what I mean.

PAMulligan commented 8 years ago

I solved that issue by changing the class to 'quickPlate' instead of 'demoPlate'. So, the controls are showing up, but it's not processing the video file correctly. I'm not really sure why, it's called properly in the asset pipeline. I'll see if I have time tonight to try out those audio files.

On Sat, Mar 5, 2016 at 2:18 PM, Nico Janssen notifications@github.com wrote:

It should only be audio files that are needed. You might be using the womAnimation.mp4 file that I have in the assets. I added a couple songs to assets/audio that you can use, 01_Raise_Your_Voices.mp3 and 02_Word_of_Mouth.mp3. The issue I was running into, was that none of the components of the music player would load except for the background. If you got to the music page, you can see what I mean.

— Reply to this email directly or view it on GitHub https://github.com/nickejanssen/WOM/issues/1#issuecomment-192751448.

nickejanssen commented 8 years ago

Great, I added the audio files in the public folder, made some changes to plate.js, and now it is playing the first song in playlist.js correctly. The playlist in the music player isnt generating correctly though. It should also play the second song as well, but isnt. I think its just a matter of adjusting the js.

I also edited the application.js required fields.

Great work by the way! Thanks again.

PAMulligan commented 8 years ago

Yes, it seems to be working! As far as the playlist issue goes, JS is not my strongest suit, so I'm gonna move on to the next issue, if that's quite alright with you.

nickejanssen commented 8 years ago

No worries, i'll work on the playlist issue. I think its a matter of syntax. Shouldnt be too problematic. Thanks for the assist!