nickel-lang / json-schema-to-nickel

Convert JSON schemas into Nickel contracts
Apache License 2.0
29 stars 0 forks source link

Re-enable some ref tests #73

Closed yannham closed 3 months ago

yannham commented 3 months ago

Depends on #72.

Enable part of the test suite on references. For now, we've simply re-enabled the tests that are passing with the current state of the repository, which at least means those won't regress in a future update. It would be better to see, for each failing test, if it's failing because it's unsupported or because there's a bug in the current implementation - this is left for a future PR (I made another pass and commented why each test doesn't pass in the current state of js2n)

yannham commented 3 months ago

I don't remember why we disabled the definitions_.* tests, could that have been because of references?

I didn't see those. I re-enabled them. They consist of two tests, one passing, and one failing because of a remote URI. I've thus only banned the failing one. That leaves one new passing test, which is something :stuck_out_tongue: