search

nickel-lang / organist

Control all your tooling from a single console
MIT License
421 stars 21 forks source link

Make the file generation more transparent #203

Closed thufschmitt closed 5 months ago

thufschmitt commented 6 months ago

Regenerate the files (defined in files.*) automatically when entering the shell (if needed).

Also unify that mechanism with the one used to generate the lockfile so that everything is generated at once.

The lockfile generation is slightly hacky because there's no easy way to pass its content from Nix to Nickel. But that'll have to do the job.

thufschmitt commented 6 months ago

It turns out that this blows-up the Nickel evaluation time (~x30 according to my benchmarks). I'll have to investigate why before we can merge this

yannham commented 6 months ago

x30 for such a change is really suspicious...

thufschmitt commented 6 months ago

x30 for such a change is really suspicious...

https://github.com/tweag/nickel/issues/1930 seems to be the culprit (possibly also the real culprit for https://github.com/tweag/nickel/issues/1630)

thufschmitt commented 5 months ago

Rebased on top of #205 . Somehow, this sidesteps the performance issue :partying_face:

thufschmitt commented 5 months ago

(Note that this accidentally includes https://github.com/nickel-lang/organist/pull/210. I can revert it if you need @yannham )