search

nickel-org / cookies

Cookie support for nickel applications
3 stars 7 forks source link

Upgrade to Support hyper-0.10 #6

Closed jolhoeft closed 6 years ago

jolhoeft commented 7 years ago

See my comments above. This may be ready to be merged.

jolhoeft commented 7 years ago

Any thoughts?

Ryman commented 6 years ago

@jolhoeft Sorry for the delay, glad to hear the encryption is still supported. I just have a concern on the blanket impl for the KeyProvider trait but other than that I think it looks good 👍

jolhoeft commented 6 years ago

I've removed the blanket impl for the KeyProvider. How does it look now?

Ryman commented 6 years ago

LGTM but I haven't seen the code executed so take my opinion with a grain of salt :D

eltomito commented 6 years ago

Could you please merge this pull request?

jolhoeft commented 6 years ago

Sorry, I let this drop off my radar.

jolhoeft commented 6 years ago

I've merged this into master, but I do not have the necessary permissions to push this to crates.io. @Ryman could you take care of that? You are the only person who can push the crate.

Ryman commented 6 years ago

@jolhoeft sorry for the delay, added you to the owners for the crate!