nickelpro / simply-portraits

Creative Commons Zero v1.0 Universal
4 stars 1 forks source link

webm tokens not showing in up in portrait #2

Closed Ikabodo closed 2 years ago

Ikabodo commented 2 years ago

Animated tokens doesn't seem to work as portraits. image

nickelpro commented 2 years ago

That's because I'm naively using an <img> tag on the clearly mistaken assumption that people only use images.

This is fixable, just need to detect media type and do the right thing

nickelpro commented 2 years ago

Ok, I have a basic fix for this.

You think that animated tokens should autoplay/loop in chat or should they be static on their first frame?

Ikabodo commented 2 years ago

Since this modules aim is to be simple, I'd say just freeze it on the first frame. :) It's too small to appriciate animation anyway.

nickelpro commented 2 years ago

I'm not fundamentally opposed to adding options, but for now I'll leave it freezed. Something to do in the future. Fixed in next release