nickelpro / simply-portraits

Creative Commons Zero v1.0 Universal
4 stars 1 forks source link

Simply Char Portraits too small for player who can't see well #3

Closed SirAron111 closed 1 year ago

SirAron111 commented 1 year ago

Is it possible to at least add an option to scale the chat portraits pixel size? And make it, so it doesn't interfere with the text itself, other than shifting it to the side. It seems to also block the tokens name coloration from midi-ql?

nickelpro commented 1 year ago

I copied the default size from the chat-portraits module, I'm happy to add an option to make the size configurable.

Would you like the option to be per-client or controlled by the DM? And can you perhaps include a screenshot of the conflict you're having with midi-qol?

SirAron111 commented 1 year ago

Controlled by the DM is better for most, since that allows these things to be preset and everyone sees the same when things are described. But since there are modules that allow one to force client settings etc, it could also be individual. if you copied it from chat portraits mod, it's probably set to 36 pixels i usually set it to 50 pixels since i don't need all the functions chat portraits provides i wanted to switch to this lighter version (gotta reduce network traffic as much as possible when self-hosting). Unbenannt Unbenannt2 Also, here are the screenshots. The midi -ql settings are the same in both pictures (set to make border and name the player color) But with portrait mod enabled, it seems to overwrite the coloring it's not a terrible conflict to live with, just thought I report it.

nickelpro commented 1 year ago

Oh weird, I'll check it out this afternoon, thanks for the report

nickelpro commented 1 year ago

Fixed in v1.2.1

The color issue isn't on my end, it's a Midi-QOL bug, opened here: https://gitlab.com/tposney/midi-qol/-/issues/1043

nickelpro commented 1 year ago

This is now fixed in midi-qol 10.0.17+