search

nickelser / activejob-traffic_control

Rate limiting/job enabling for ActiveJob using distributed locks in Redis or Memcached.
305 stars 28 forks source link

Use #class_attribute instead of #attr_accessor #1

Closed avokhmin closed 8 years ago

avokhmin commented 8 years ago

See: https://github.com/rails/rails/blob/v5.0.0.1/activejob/lib/active_job/queue_priority.rb#L29-L33

Also, it prevents wrong data in inherited classes.

avokhmin commented 8 years ago

@nickelser something wrong here?

nickelser commented 8 years ago

@avokhmin for some reason I had unwatched my own repository, so I missed out on this PR; many apologies! This is a great catch and I'll merge/release ASAP.

nickelser commented 8 years ago

Released v0.1.2 (https://github.com/nickelser/activejob-traffic_control/releases/tag/v0.1.2)

avokhmin commented 8 years ago

@nickelser , thanks 👍