A few potential improvements

nickelser / activejob-traffic_control

Rate limiting/job enabling for ActiveJob using distributed locks in Redis or Memcached.

305 stars 28 forks source link

A few potential improvements #2

Closed ankane closed 7 years ago

ankane commented 7 years ago

Bundled into one commit, but happy to rebase only the ones you want.

No longer need to require "active_job/traffic_control"
Includes all features by default
Uses lazy loading with ActiveSupport.on_load
Defaults to drop: false for concurrency (seems safer)

ankane commented 7 years ago

Not sure why tests are failing, they pass locally with the same seed.

nickelser commented 7 years ago

You got to it before I could! Awesome job; I rebuilt your changes and it worked great, so probably a Travis/fickle-ness issue (though, I haven't seen that before?). Will merge & release new version.