search

nickeltea / pe

0 stars 0 forks source link

Person with same name but different details cannot be added to list. #3

Open nickeltea opened 1 year ago

nickeltea commented 1 year ago

image.png

image.png

The commands shown in the screenshots above cannot be executed due to a duplicate person error.

There are many people with the same name but different details. As can be seen, the person Betsy Crowe exists in the list but the details of the person being added are all different (email, phone, tags), thus it is likely that the new person being added is not not the same as the one in the list.

As such, the feature becomes less useful for normal usage, making this a feature flaw.

Severity is low as though this can inconvenience many people, the app is largely still usable and the inconvenience is not great.

nus-se-script commented 1 year ago

Team's Response

Thanks for the bug report!

Good catch! We are currently disallowing multiple people with the same name to be added to our application as we hope to allow commands to take in people's names instead of indices only in future - e.g. add member "John Doe" should add John Doe to the current team. To enable this extension, we require the constraint of non-duplicate names.

In any case, we acknowledge that this might prove to be a minor inconvenience but we feel it is not within the scope of this version of the product to be able to address this issue.

Hence, we are marking this issue as not in scope, but we do appreciate the suggestion to include this feature in future :)

Have a nice reading week!

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Hi!

While I understand the reasoning behind this decision, kindly note that this situation is very similar to a given example of a feature flaw on the module website as can be seen in the screenshot below.

As stated in the given example, "often, detecting only the exact string/value matches is not enough" and "If you app has a duplicate detection feature, make sure its limitations are made clear to the user so that users are not led to believe that duplicates are being detected while many potential duplicate cases go undetected". This behaviour is not specified in the user guide and thus users are led to believe duplicates are being detected with no warning.

image.png