Closed GoogleCodeExporter closed 8 years ago
Needs a test case.
Original comment by philhas...@gmail.com
on 18 Jun 2008 at 11:15
I've found that the strip() method of strings had a similar problem (used
strlen()
instead of foo.string.len) while I was writing the test, so I patched up that
as well
(test included).
Original comment by denis.ka...@gmail.com
on 19 Jun 2008 at 12:40
Attachments:
You should probably break this into two separate patches .. but don't bother
this time :)
The strip patch is a bit long and won't work. If it is passed something other
than a
string it will have undefined behavior. You want to use TP_TYPE(TP_STRING); to
get
your parameter to assert that it is a string. After that, you can make things
a bit
more concise.
Original comment by philhas...@gmail.com
on 20 Jun 2008 at 2:51
How's this revised version?
Original comment by denis.ka...@gmail.com
on 19 Jul 2008 at 2:28
Attachments:
I think that looks good, feel free to commit this fix.
Original comment by philhas...@gmail.com
on 24 Jul 2008 at 7:49
Original comment by denis.ka...@gmail.com
on 25 Jul 2008 at 8:53
Original issue reported on code.google.com by
denis.ka...@gmail.com
on 18 Jun 2008 at 4:07Attachments: