search

nickethier / grokdebug

grokdebug.herokuapp.com
Other
123 stars 56 forks source link

Fix the case where the matched strings contain HTML chars that need escaping #5

Closed shadyabhi closed 10 years ago

shadyabhi commented 10 years ago

For the idea of what the issue is,

Not working: 2013-11-26-153319_965x309_scrot

After the patch: 2013-11-26-153435_969x353_scrot

Basically, I've used CGI.escapeHTML to escape the strings while sending back json data to browser.

shadyabhi commented 10 years ago

I see that this is still not fixed. Can we get this merged?

Thanks

nickethier commented 10 years ago

Yes thankyou! Sorry for not getting this merged sooner. I'll get this pushed out in a bit.