Closed nickeubank closed 2 years ago
@PranavM98 you can find my edits to your file in the first commit. Now I'm on a bit of a re-naming blitz, so the full list of changes may be a bit overwhelming, but that ifrst diff should be helpful.
@nickeubank , Thank you very much for these reviews!
@PranavM98 OK, also re-worked the merge with demographic data. Note that there's a potentially BIG issue with the merge -- basically, it's a many-to-many merge which does all sorts of weird things. Take a look at this reading on validating merges, and make sure that this one is behaving well.
I renamed that file too, which corrupted the diff, but you can see it here: https://github.com/nickeubank/mtv_viacom_capstone/pull/46/commits/d10b27809106604b26352669e03eddcb78a9abbb
@PranavM98 I went through your import file and made some changes. Please take a look and let me know what you think. In particular:
if __name__=='__main__':
style of file organization for these types of projects. It doesn't add anything, but makes running the code a few lines at a time (and interrogating results as you go) more difficult, so I removed that.geo_df = geo_df.assign(x_centroid=lambda x: (x["centroid"].x))
) is a very strange idiom -- the normal pandas way to do this would just begeo_df["centroid_long"] = geo_df["centroid"].x
.