search

nickg / nvc

VHDL compiler and simulator
https://www.nickg.me.uk/nvc/
GNU General Public License v3.0
589 stars 75 forks source link

Testsuite does not pass on macos sonoma (intel mac) #869

Closed yikkrubz closed 3 months ago

yikkrubz commented 3 months ago

The testsuite does not pass for the current git version. The test for issue 856 fails.

     ename8 : ok
   issue856 : failed (waveform mismatch)

/Users/Peter/Downloads/nvc/build/bin/nvc --std=2019 -a /Users/Peter/Downloads/nvc/test/regress/issue856.vhd -e issue856 -O0 --no-save -r -w --dump-arrays issue856 ** Note: writing FST waveform data to issue856.fst /Users/Peter/Downloads/nvc/build/bin/fstdump -o issue856.dump issue856.fst /usr/bin/diff -u /Users/Peter/Downloads/nvc/test/regress/gold/issue856.dump issue856.dump --- /Users/Peter/Downloads/nvc/test/regress/gold/issue856.dump 2024-03-13 23:31:14 +++ issue856.dump 2024-03-23 16:08:39 @@ -1,14 +1,14 @@ -#0 issue856.b.p[1].g 0000000000000000000000000001101100000000000000000000000000011011 -#0 issue856.b.p[1].f[3].y 0000000000000000000000000000011100000000000000000000000000000111 -#0 issue856.b.p[1].f[3].x 0000000000000000000000000000011000000000000000000000000000000110 -#0 issue856.b.p[1].f[2].y 0000000000000000000000000000010100000000000000000000000000000101 -#0 issue856.b.p[1].f[2].x 0000000000000000000000000000010000000000000000000000000000000100 -#0 issue856.b.p[1].f[1].y 0000000000000000000000000000001100000000000000000000000000000011 -#0 issue856.b.p[1].f[1].x 0000000000000000000000000000001000000000000000000000000000000010 -#0 issue856.s.g 0000000000000000000000000001101100000000000000000000000000011011 -#0 issue856.s.f[3].y 0000000000000000000000000000011100000000000000000000000000000111 -#0 issue856.s.f[3].x 0000000000000000000000000000011000000000000000000000000000000110 -#0 issue856.s.f[2].y 0000000000000000000000000000010100000000000000000000000000000101 -#0 issue856.s.f[2].x 0000000000000000000000000000010000000000000000000000000000000100 -#0 issue856.s.f[1].y 0000000000000000000000000000001100000000000000000000000000000011 -#0 issue856.s.f[1].x 0000000000000000000000000000001000000000000000000000000000000010 +#0 issue856.b.p[1].g 0000000000000000000000000000000000000000000000000000000000011011 +#0 issue856.b.p[1].f[3].y 0000000000000000000000000000000000000000000000000000000000000111 +#0 issue856.b.p[1].f[3].x 0000000000000000000000000000000000000000000000000000000000000110 +#0 issue856.b.p[1].f[2].y 0000000000000000000000000000000000000000000000000000000000000101 +#0 issue856.b.p[1].f[2].x 0000000000000000000000000000000000000000000000000000000000000100 +#0 issue856.b.p[1].f[1].y 0000000000000000000000000000000000000000000000000000000000000011 +#0 issue856.b.p[1].f[1].x 0000000000000000000000000000000000000000000000000000000000000010 +#0 issue856.s.g 0000000000000000000000000000000000000000000000000000000000011011 +#0 issue856.s.f[3].y 0000000000000000000000000000000000000000000000000000000000000111 +#0 issue856.s.f[3].x 0000000000000000000000000000000000000000000000000000000000000110 +#0 issue856.s.f[2].y 0000000000000000000000000000000000000000000000000000000000000101 +#0 issue856.s.f[2].x 0000000000000000000000000000000000000000000000000000000000000100 +#0 issue856.s.f[1].y 0000000000000000000000000000000000000000000000000000000000000011 +#0 issue856.s.f[1].x 0000000000000000000000000000000000000000000000000000000000000010 driver22 : ok vhpi12 : ok issue862 : ok issue858 : ok 1 failures! FAIL: bin/run_regr

macos 14.4 (intel)

nickg commented 3 months ago

I think the "wrong" results are above are actually correct and this is exposing some undefined behaviour in the way >32 bit integer types are dumped to FST. Should be fixed now.