Open cyberluke opened 8 years ago
Hey, yes I'm trying to replace all the old saveModelToFile/loadModelFromFile functions to the newer save/load functions.
If there are still some I've missed then fixing these and sending a pull request would be great!
I've noticed some remaining methods saveModelToFile and loadModelFromFile. In my case I've replaced them by save
and load
. Should I create a pull request with these changes or is there a specific reason why the methods are still exitsting @nickgillian ?
Replacing the methods should fix this issue.
Update: I've added the changes in my pull request: #155
Hi, I use master branch. Visual Studio 2015 created grt.lib and examples with no problems. Now I want to try your basic example and linker has problems. There are a lot of places, where saveModelToFile is used instead of save. I'm watching your discussion, so I know that you changed it. Do you want me to replace it and send pull request?
Severity Code Description Project File Line Suppression State Error C4996 'GRT::MLBase::saveModelToFile': saveModelToFile(std::fstream &file) is deprecated, use save(std::fstream &file) instead NanoSuitSrv c:\bitbucket\grt\grt\coremodules\FeatureExtraction.h 107