search

nickgillian / grt

gesture recognition toolkit
859 stars 285 forks source link

Adding unit tests for more classifiers #97

Closed narner closed 7 years ago

narner commented 7 years ago

Hey Nick,

I started adding in some more unit tests for the Classifier modules. Right now, the test files are only testing the TrainBasicDataset methods, but I'm going to look at other tests as well. Hope this is a helpful start to getting in more tests!

nickgillian commented 7 years ago

Great, thanks for the contributions!

I attempted to merge your commit, but it failed as there were a number of syntax issues (that stopped the unit tests from compiling).

I fixed the issues and merge the changes into my dev branch. Can you pull from that and sync to get the changes. I also made several updates to the base classifier and pushed several general function calls to that, so if you see loads of changes there then know this is separate from your commit.

narner commented 7 years ago

Glad they're helpful! Sounds good, I think I see those syntax errors. Will be sure to pull.

narner commented 7 years ago

Hey @nickgillian, I pulled the latest changes from the develop branch. When running the tests, I noticed three things:

  1. The GMMTest no longer passes
  2. The SwipeDetectorTest no longer passes
  3. The SoftmaxTest now takes a very long time to pass (1164.78 seconds).

I went back and looked at the latest changes, but didn't see anything obviously wrong as to why these errors now occur.