search

nickgood / stoves_nih_2016_git

Code for processing the STOVES study dataset
2 stars 1 forks source link

Su kf analysis #186

Closed KFedak closed 7 years ago

KFedak commented 7 years ago

adding analysis to the overall startup study branch

nickgood commented 7 years ago

Can you add the new data files to my drive so I can run the new .Rmd?

Nicholas Good, BSc. PhD. Environmental and Radiological Health Sciences Colorado State University Fort Collins Colorado 80523-1681

Tel: +1.970.491.7607 Alt: +1.970.310.3750 Email: n.good@colostate.edumailto:n.good@colostate.edu

On Oct 17, 2017, at 17:40, Kristen Fedak notifications@github.com<mailto:notifications@github.com> wrote:

@KFedakhttps://github.com/kfedak requested your review on: nickgood/stoves_nih_2016_git#186https://github.com/nickgood/stoves_nih_2016_git/pull/186 Su kf analysis.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/nickgood/stoves_nih_2016_git/pull/186#event-1297847226, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANTghoEmNUwCxWBJogMYgcHxJ853wzWvks5stR69gaJpZM4P83Ht.

KFedak commented 7 years ago

oh right... I just uploaded the "supporting data" folder to your drive so the new .rmd should run. However, I think I actually don't want to merge that file into the master - just the changes to the emissions_analysis_perstartup.Rmd. After further discussion with John and Jennifer, I stopped going the route I was going with that global use estimate, so that rmd is not complete or necessary to be in the startup master. Is accepting just the perstartup.rmd changes something we can do from this merge request or do I need to cancel this one and set it up differently?

ngood13 commented 7 years ago

Should be fine as is :)

Sent from my T-Mobile 4G LTE Device

-------- Original message -------- From: Kristen Fedak notifications@github.com Date: 10/19/17 12:45 PM (GMT-05:00) To: nickgood/stoves_nih_2016_git stoves_nih_2016_git@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [nickgood/stoves_nih_2016_git] Su kf analysis (#186)

oh right... I just uploaded the "supporting data" folder to your drive so the new .rmd should run. However, I think I actually don't want to merge that file into the master - just the changes to the emissions_analysis_perstartup.Rmd. After further discussion with John and Jennifer, I stopped going the route I was going with that global use estimate, so that rmd is not complete or necessary to be in the startup master. Is accepting just the perstartup.rmd changes something we can do from this merge request or do I need to cancel this one and set it up differently?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/nickgood/stoves_nih_2016_git/pull/186#issuecomment-337967225, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARvMcE1dHty7FLYmDJXP4FRl-IMicCpBks5st3wwgaJpZM4P83Ht.

KFedak commented 7 years ago

:smile: :+1:

nickgood commented 7 years ago

add in kristen's updates