search

nickguletskii / GLXOSD

GLXOSD is an extensible on-screen display (OSD)/overlay for OpenGL applications running on Linux with X11 which aims to provide similar functionality to MSI Afterburner/RivaTuner OSD. It can show FPS, frame timings, temperatures and more in OpenGL games and applications. It can also be used to benchmark games, much like voglperf.
https://glxosd.nickguletskii.com
MIT License
123 stars 20 forks source link

make it build on systems using /usr/lib64 #65

Closed kparal closed 8 years ago

kparal commented 8 years ago

Do not hardcode <prefix>/lib/ as a library path, that is used in Debian, but not in many other distributions (e.g. Fedora). Use GNUInstallDirs cmake module to automatically get the proper location for your distribution.

A relevant discussion is here: https://cmake.org/pipermail/cmake/2013-July/055371.html The cmake module is documented here: https://cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html

This patch helped me to build glxosd on Fedora (when run as cmake -DCMAKE_INSTALL_PREFIX=/usr -DINSTALLATION_SUFFIX_64=lib64 -DINSTALLATION_SUFFIX_32=lib -G "Unix Makefiles").

Please note that I'm not a C developer and I have no experience with cmake, so please make sure this still builds well for you on Debian/Ubuntu.

nickguletskii commented 8 years ago

Thank you. I'll merge this once I get the chance to recheck the Debian packages.

nickguletskii commented 8 years ago

The CMake files in GLXOSD version 3 use GNUInstallDirs wherever it is possible. Thank you very much for reporting this issue and thank you very much for your pull request.