Fix for ubuntu 22.04 apt key deprecated error

[devjume]

Error to fix

Current version of role uses ansible.builtin.apt_key to add Dockers public GPG key to the APT keyring. This causes following error when running apt update on Ubuntu 22.04 (and Debian 11?): Key is stored in legacy trusted.gpg keyring (/etc/apt/trusted.gpg), see the DEPRECATION section in apt-key(8) for details. Read more about the why this is here in the summary

Fix

• Added signed-by=/etc/apt/keyrings/docker.asc to docker__apt_repository variable
• Changed ansible.builtin.apt_key module to ansible.builtin.get_url module to download and save GPG key.
  • Note: saved as .asc filetype See
• Added task to create /etc/apt/keyrings/ directory just in case it doesn't exit

Read More / References: ansible.builtin.apt_key adds keys to a deprecated location #78063 apt_key deprecated in Debian/Ubuntu - how to fix in Ansible Used this commit as reference for the fix

[nickjj]

Hi,

Are you still open to merging this? I see there's a conflict but, if you are open to pursuing this PR still I'd like to make a number of suggestions before we can merge it.

If not, it's all good. I know this PR was hanging for almost a year.

[devjume]

Hi,

Unfortunately I don't have time to work on this now or anytime soon.

[nickjj]

It's ok.

If anyone is curious, this underlying issue was resolved in v2.3.0+.